Skip to content

Add model autoconfigure - #110

Merged
thomasturrell merged 29 commits into
mainfrom
polish-polish
Apr 4, 2023
Merged

Add model autoconfigure#110
thomasturrell merged 29 commits into
mainfrom
polish-polish

Conversation

@Selindek

@Selindek Selindek commented Apr 3, 2023

Copy link
Copy Markdown
Contributor

Description

Resolves # (issue)

Checklist:

  • Public methods are documented
  • Public methods are tested
  • New and existing tests pass when run locally
  • There are no new warnings or errors

@Selindek
Selindek requested a review from thomasturrell April 3, 2023 07:56
Comment thread xapi-model/src/main/java/dev/learning/xapi/jackson/StrictLocaleDeserializer.java Outdated
Comment thread xapi-model/src/main/java/dev/learning/xapi/jackson/XapiStrictLocaleModule.java Outdated

@thomasturrell thomasturrell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check all files:

  • for use of xAPI. It should be xAPI in text and Xapi in class names.
  • that the Copyright message is the same (lots of errors in dates)

@thomasturrell thomasturrell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run mvn javadoc:javadoc and fix any problems that you find.

Comment thread xapi-model/src/main/java/dev/learning/xapi/model/SubStatement.java
Comment thread xapi-model/src/main/java/dev/learning/xapi/model/SubStatementObject.java Outdated
Comment thread xapi-model/src/main/java/dev/learning/xapi/model/Statement.java Outdated
Comment thread xapi-model/src/main/java/dev/learning/xapi/model/Statement.java Outdated
Comment thread xapi-model/src/test/java/dev/learning/xapi/model/StatementTests.java Outdated
Comment thread xapi-model/src/test/java/dev/learning/xapi/model/StatementTests.java Outdated
Base automatically changed from polish-xapi-server-sample to main April 3, 2023 21:57
Comment thread pom.xml Outdated
@thomasturrell thomasturrell changed the title Polish polish Add model autoconfigure Apr 4, 2023
Comment thread samples/xapi-server/src/main/resources/application.properties Outdated
@sonarqubecloud

sonarqubecloud Bot commented Apr 4, 2023

Copy link
Copy Markdown

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

63.0% 63.0% Coverage
0.0% 0.0% Duplication

@thomasturrell
thomasturrell merged commit 1eda3c5 into main Apr 4, 2023
@thomasturrell
thomasturrell deleted the polish-polish branch April 5, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants